Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Rewrite README (& add echo.rs example) #2960

Merged
merged 8 commits into from
Nov 26, 2024
Merged

Conversation

matheus23
Copy link
Member

Description

  • Rewrote the README
  • Renamed iroh-router/examples/custom-protocol.rs to search.rs (It's not a "custom" protocol. Just a protocol.) Removed "custom" wording
  • Added a simpler echo.rs example (used in the README)

Notes & open questions

  • In the "repository structure" section, I describe the purpose of some crates, but not all. Since stuff will be moving around in the coming weeks, I think that's, fine, but someone please tell me if we should do sth differently there.

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@matheus23 matheus23 self-assigned this Nov 22, 2024
Copy link

github-actions bot commented Nov 22, 2024

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2960/docs/iroh/

Last updated: 2024-11-26T11:52:34Z

Copy link

github-actions bot commented Nov 22, 2024

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 7dc49c5

@matheus23 matheus23 requested a review from a team November 25, 2024 09:31
Copy link
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@matheus23 matheus23 added this to the v0.29.0 milestone Nov 25, 2024
@matheus23 matheus23 enabled auto-merge November 26, 2024 11:47
@matheus23 matheus23 added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit 4abfd61 Nov 26, 2024
25 of 26 checks passed
@dignifiedquire dignifiedquire deleted the matheus23/readme branch November 26, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants