Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): netsim commenting fixes #2766

Merged
merged 2 commits into from
Oct 1, 2024
Merged

fix(ci): netsim commenting fixes #2766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d7d41b
fix(ci): netsim commenting fixes
Arqu Oct 1, 2024
d7eda1d
fix perms
Arqu Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,7 @@ jobs:
command-arguments: "-Dwarnings"

netsim-integration-tests:
permissions: write-all
if: "github.event_name != 'pull_request' || ! contains(github.event.pull_request.labels.*.name, 'flaky-test')"
uses: './.github/workflows/netsim_runner.yaml'
secrets: inherit
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/docs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@ env:

jobs:
preview_docs:
permissions:
issues: write
contents: write
permissions: write-all
timeout-minutes: 30
name: Docs preview
if: ${{ (github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch' ) && !github.event.pull_request.head.repo.fork }}
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/netsim.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ env:

jobs:
netsim-release:
permissions: write-all
if: ${{github.ref_name=='main' && github.event_name == 'push'}}
uses: './.github/workflows/netsim_runner.yaml'
secrets: inherit
Expand All @@ -44,6 +45,7 @@ jobs:
build_profile: "optimized-release"

netsim-perf:
permissions: write-all
if: ${{github.event_name != 'push'}}
uses: './.github/workflows/netsim_runner.yaml'
secrets: inherit
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/netsim_runner.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ env:

jobs:
netsim:
permissions: write-all
name: Netsim
timeout-minutes: 45
runs-on: [self-hosted, linux, X64]
Expand All @@ -112,7 +113,7 @@ jobs:

- name: Build iroh
run: |
cargo build --profile ${{ inputs.build_profile }} --workspace --all-features
cargo build --profile ${{ inputs.build_profile }} --workspace --all-features --examples --bins

- name: Fetch and build chuck
run: |
Expand All @@ -131,6 +132,7 @@ jobs:

- name: Copy binaries to right location
run: |
cp target/${{inputs.build_profile}}/examples/* ../chuck/netsim/bins/
cp target/${{inputs.build_profile}}/iroh ../chuck/netsim/bins/iroh
cp target/${{inputs.build_profile}}/iroh-relay ../chuck/netsim/bins/iroh-relay
cp ../chuck/target/release/chuck ../chuck/netsim/bins/chuck
Expand Down Expand Up @@ -196,13 +198,13 @@ jobs:
with:
issue-number: ${{ inputs.pr_number }}
comment-author: 'github-actions[bot]'
body-includes: Netsim report for this PR has been generated
body-includes: Netsim report & logs for this PR have been generated

- name: Create or Update Docs Comment
if: ${{ inputs.pr_number != '' }}
uses: peter-evans/create-or-update-comment@v4
with:
issue-number: ${{ github.event.pull_request.number }}
issue-number: ${{ inputs.pr_number }}
comment-id: ${{ steps.fc.outputs.comment-id }}
body: |
Netsim report & logs for this PR have been generated and is available at: [LOGS](${{steps.upload-report.outputs.artifact-url}})
Expand Down
Loading