Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(iroh-net): Remove direct dependency on rand_core #2719

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

flub
Copy link
Contributor

@flub flub commented Sep 6, 2024

Description

This is small and doesn't really affect anything, but removes the
direct dependency on rand_core. There's no need for it.

Breaking Changes

None

Notes & open questions

I was looking for easy wins on the dependencies. I guess this wasn't
really it...

Change checklist

  • Self-review.
  • [ ] Documentation updates following the style guide, if relevant.
  • [ ] Tests if relevant.
  • [ ] All breaking changes documented.

This is small and doesn't really affect anything, but removes the
direct dependency on rand_core.  There's no need for it.
@flub
Copy link
Contributor Author

flub commented Sep 6, 2024

Typo failure fixed in #2718

Copy link

github-actions bot commented Sep 6, 2024

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2719/docs/iroh/

Last updated: 2024-09-06T14:01:39Z

@flub flub requested a review from Frando September 6, 2024 14:53
Copy link
Contributor

@divagant-martian divagant-martian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@divagant-martian divagant-martian added this pull request to the merge queue Sep 7, 2024
Merged via the queue into main with commit b6a64e0 Sep 7, 2024
26 of 28 checks passed
@flub flub deleted the flub/no-rand-core branch October 4, 2024 08:49
matheus23 pushed a commit that referenced this pull request Nov 14, 2024
## Description

This is small and doesn't really affect anything, but removes the
direct dependency on rand_core.  There's no need for it.

## Breaking Changes

None

## Notes & open questions

I was looking for easy wins on the dependencies.  I guess this wasn't 
really it...

## Change checklist

- [x] Self-review.
- ~~[ ] Documentation updates following the [style
guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text),
if relevant.~~
- ~~[ ] Tests if relevant.~~
- ~~[ ] All breaking changes documented.~~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants