fix(iroh-net): prevent adding addressing info that points back to us #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flub
reviewed
May 29, 2024
|
@divagant-martian what's missing from this to be ready? |
flub
approved these changes
Jun 18, 2024
| pub fn add_node_addr(&self, addr: NodeAddr) { | ||
| self.node_map.add_node_addr(addr); | ||
| pub fn add_node_addr(&self, mut addr: NodeAddr, source: node_map::Source) -> Result<()> { | ||
| let my_addresses = self.endpoints.get().last_endpoints; |
There was a problem hiding this comment.
if you felt like renaming self.endpoints here to self.direct_addresses or something i would not object... :) But I can also do this separately.
There was a problem hiding this comment.
I left it out. It feels out of scope since I'm not changing the field, simply using it here
ppodolsky
pushed a commit
to izihawa/iroh
that referenced
this pull request
Jun 22, 2024
…0-computer#2333) ## Description Failed disco boxes for which the sender is our own node is are because we tried to contact another node for which the addressing information we have points back to us. We are the sender (this explains the source of the disco box being ourselves) but we are not the meant recipient (thus the failed decryption - we should always be able to decrypt a message meant to ourselves - ). This is of course undesirable. This Pr should mostly mitigate this issue, but a failed disco box to ourselves can happen in other less likely ways. ## Breaking Changes n/a ## Notes & open questions n/a ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [ ] ~Tests if relevant.~ - [ ] ~All breaking changes documented.~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Failed disco boxes for which the sender is our own node is are because we tried to contact another node for which the addressing information we have points back to us. We are the sender (this explains the source of the disco box being ourselves) but we are not the meant recipient (thus the failed decryption - we should always be able to decrypt a message meant to ourselves - ).
This is of course undesirable. This Pr should mostly mitigate this issue, but a failed disco box to ourselves can happen in other less likely ways.
Breaking Changes
n/a
Notes & open questions
n/a
Change checklist
Tests if relevant.All breaking changes documented.