fix(sync): properly drop rpc subscriptions, add doc status #1396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So far in #1333, if a RPC or in-memory client called
doc.subscribe()
the event callback would never be dropped, even if the client did drop the event stream. This PR fixes this, by having the event callbacks return whether the callback should stay active or not. We can't use the removal token here, because callingLiveSync::unsubscribe
from within the event callback would deadlock the actor.Also adds a a
LiveStatus
to the doc info RPC call. For now only contains the number of subscribers. More info, e.g. on peers, can come later.Notes & open questions
doc.subscribe
will fail for documents that are not in theLiveSync
(they are added viadoc.import
ordoc.start_sync
). This is unfortunate, because you'd often want to setup a subscription before starting sync, to catch all events.Change checklist