-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove now deprecated flat stores #2630
Comments
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 15, 2024
## Description In vein of promoting doing things TheRightWay™, this PR deprecates flat stores for their removal in a later iroh version. This is probably a low stakes deprecation and removal but imo gets us in the flow of being kind(er) with our users. Issue #2630 is created as a reminder to remove this. ## Breaking Changes - `iroh_blobs::store::fs::Store::import_flat_store` is deprecated. Ensure all data is migrated before future versions, which won't support this. - `iroh_blobs::store::fs::FlatStorePaths` is deprecated. Ensure all data is migrated before future versions, which won't support this. - `iroh`: Flat stores are deprecated. Ensure all data is migrated before future versions, which won't support this. ## Notes & open questions n/a ## Change checklist - [x] Self-review. - [ ] ~~Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant.~~ - [ ] ~~Tests if relevant.~~ - [x] All breaking changes documented.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See #2629
Removal should be done after a version that contains the deprecation is published (0.23), so v0.24 the earliest
The text was updated successfully, but these errors were encountered: