feat(iroh-net)!: remove fs based peers storage #2510
Conversation
There was a problem hiding this comment.
In principle I like this.
The important part is getting back the saving functionality that used to be in iroh-net.
Ideally we bring back the same "save on tick" functionality where the peer map is saved.
Perhaps we can even save it in redb instead? That could be nicer for something that may be a little more corruption resistant.
iroh-net/src/endpoint.rs
Outdated
| @@ -771,6 +767,11 @@ impl Endpoint { | |||
| self.msock.conn_type_stream(node_id) | |||
| } | |||
|
|
|||
| /// Get the known node addresses which should be persisted. | |||
| pub fn node_addresses_for_storage(&self) -> Vec<NodeAddr> { | |||
| self.msock.node_addresses_for_storage() | |||
There was a problem hiding this comment.
This information can already be constructed from the Endpoint::connection_infos response. Maybe it makes more sense to add a From<ConnectionInfo> for NodeAddr impl?
There was a problem hiding this comment.
good idea, done
There was a problem hiding this comment.
I'm not sure this is the same. The previous code saved only the verified paths of used nodes and all paths of unverified nodes. Now, as far as i can tell, we will store again paths not active/used for nodes with known verified paths
There was a problem hiding this comment.
@divagant-martian should be fixed, the filtering is happening now at the node layer
This sounds like |
|
I implemented a timer based version of storage again, which I think works well enough for now |
dignifiedquire
force-pushed
the
feat-move-node-storage
branch
from
396623f
to
7a4293c
Compare
|
lgtm i think |
dignifiedquire
force-pushed
the
feat-move-node-storage
branch
from
38200be
to
43fdcac
Compare
dignifiedquire
force-pushed
the
feat-move-node-storage
branch
from
2d4d789
to
19be4ef
Compare
Instead introduces - `endpoint::Builder::known_nodes` to provide existing `NodeAddr`s - `endpoint::Endpoint::node_addresses_for_storage` to retrieve the current list of known nodes that can be persisted
dignifiedquire
force-pushed
the
feat-move-node-storage
branch
from
0655523
to
65ef47a
Compare
| @@ -1478,6 +1465,8 @@ pub struct DirectAddrInfo { | |||
| pub last_control: Option<(Duration, ControlMsg)>, | |||
| /// How long ago was the last payload message for this node. | |||
| pub last_payload: Option<Duration>, | |||
| /// When was this connection last alive, if ever. | |||
| pub last_alive: Option<Duration>, | |||
There was a problem hiding this comment.
This might be redundant, tldr this is the max between the two above. But it's harmless anyway
Description
Instead introduces
endpoint::Builder::known_nodesto provide existingNodeAddrsendpoint::Endpoint::connection_infosto retrieve the current list of known nodes that can be persistedNotes
prune_inactiveis not called anymore when storing, only on the heartbeat, and so there is a chance of storing uninteresting addressesBreaking Changes
endpoint::Builder::peers_pathis removediroh-netTODO
iroh