Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flaky test: iroh-net endpoint::tests::save_load_peers #2504

Closed
dignifiedquire opened this issue Jul 15, 2024 · 2 comments
Closed

flaky test: iroh-net endpoint::tests::save_load_peers #2504

dignifiedquire opened this issue Jul 15, 2024 · 2 comments

Comments

@dignifiedquire
Copy link
Contributor

test endpoint::tests::save_load_peers ... FAILED

failures:

failures:
    endpoint::tests::save_load_peers

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 106 filtered out; finished in 11.83s


--- STDERR:              iroh-net endpoint::tests::save_load_peers ---
thread 'endpoint::tests::save_load_peers' panicked at iroh-net\src\endpoint.rs:1302:82:
called `Option::unwrap()` on a `None` value

https://github.com/n0-computer/iroh/actions/runs/9939026148/job/27452760889

@flub
Copy link
Contributor

flub commented Jul 16, 2024

The flakyness here is a race condition between the NodeMap loading the peers from the file and the test requesting this info. It will likely be solved by #2510 and is probably best to address there.

@dignifiedquire
Copy link
Contributor Author

Test is gone

@github-project-automation github-project-automation bot moved this to ✅ Done in iroh Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants