Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netcheck report does not finish early enough #2021

Closed
flub opened this issue Feb 12, 2024 · 1 comment · Fixed by #2027
Closed

netcheck report does not finish early enough #2021

flub opened this issue Feb 12, 2024 · 1 comment · Fixed by #2027
Assignees
@flub
Labels
bug Something isn't working c-iroh
Milestone
v0.13.0

Comments

@flub
Copy link
Contributor

flub commented Feb 12, 2024

I have a netcheck report where we have established connectivity to the derper and figured out our IPv4 STUN addresses very quickly, yet keep waiting for all probes much, much to long. In fact it logs Have enough probe reports, aborting further probes soon and yet it waits forever for to actually abort. This wreaks havoc with good connection establishment.

Splitting this off to keep #1984 somewhat limited in scope.

Relevant log: https://gist.github.com/flub/1d503f757bc1e275e417d0d918b66604
@flub flub added bug Something isn't working c-iroh labels Feb 12, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in iroh Feb 12, 2024
@dignifiedquire dignifiedquire added this to the v0.14.0 milestone Feb 12, 2024
@dignifiedquire
Copy link
Contributor

I suspected this behaviour as well when reading logs for a while, but could never quite nail it.

@flub flub self-assigned this Feb 15, 2024
@flub flub mentioned this issue Feb 15, 2024
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Feb 16, 2024
@flub
fix(iroh-net): Ensure netcheck finishes once it has results (#2027)
c62950e 
## Description

Once netcheck has managed to establish an external IP address there is
no need to further wait on the portmapper.  The results are already
useful.  If later the portmapper manages to get something done the
magicsock will react to that and make use of it.

## Notes & open questions

Fixes #2021

## Change checklist

- [x] Self-review.
- [x] Documentation updates if relevant.
- [x] Tests if relevant.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in iroh Feb 16, 2024
@dignifiedquire dignifiedquire modified the milestones: v0.14.0, v0.13.0 Feb 19, 2024
fubuloubu pushed a commit to ApeWorX/iroh that referenced this issue Feb 21, 2024
@flub @fubuloubu
fix(iroh-net): Ensure netcheck finishes once it has results (n0-compu…
73b5822 
…ter#2027)

## Description

Once netcheck has managed to establish an external IP address there is
no need to further wait on the portmapper.  The results are already
useful.  If later the portmapper manages to get something done the
magicsock will react to that and make use of it.

## Notes & open questions

Fixes n0-computer#2021

## Change checklist

- [x] Self-review.
- [x] Documentation updates if relevant.
- [x] Tests if relevant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flub flub

Labels
bug Something isn't working c-iroh
Projects
iroh
Archived in project
Milestone
v0.13.0
Development

Successfully merging a pull request may close this issue.

fix(iroh-net): Ensure netcheck finishes once it has results n0-computer/iroh
2 participants
@flub @dignifiedquire