Audit usage of unwraps #1528
Comments
flub
added a commit
that referenced
this issue
Sep 26, 2023
This response is not critical. If someone dropped the receiver it's just fine, it meant they didn't care about the response anymore. This has occurred during shutdown. Part of #1528
3 tasks
3 tasks
|
I'm splitting this as they are unrelated and closed by different solutions #1531 |
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 27, 2023
## Description This response is not critical. If someone dropped the receiver it's just fine, it meant they didn't care about the response anymore. This has occurred during shutdown. Part of #1528 ## Notes & open questions ## Change checklist - [x] Self-review. - [x] ~~Documentation updates if relevant.~~ - [x] ~~Tests if relevant.~~
github-project-automation
bot
moved this from 📋 Backlog - unassigned issues
to ✅ Done
in iroh
github-project-automation
bot
moved this from ✅ Done
to 📋 Backlog - unassigned issues
in iroh
|
We should still audit other places for this. But it's painfully manual and error-prone. |
flub
added a commit
that referenced
this issue
Feb 28, 2024
This is an attempt at an audit of all the .unwrap() calls in iroh-net. A few are replaced by .expect() with clear reasons why they're reasonable. Some are replaces by non-panicking versions which will never take the failure branch because of the invariants that are supposed to be upheld. Closes #1528
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 29, 2024
## Description This is an attempt at an audit of all the .unwrap() calls in iroh-net. A few are replaced by .expect() with clear reasons why they're reasonable. Some are replaces by non-panicking versions which will never take the failure branch because of the invariants that are supposed to be upheld. Closes #1528 ## Notes & open questions This was surprisingly horrible and long to do. Oh well. Worth reviewing in detail I'm afraid. ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [x] Tests if relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
thread 'sync_big' panicked at 'called Result::unwrap() on an Err value: ()', iroh/iroh-net/src/magicsock.rs:1175:28. This happened at the end of the test, after callingnode.shutdown()The text was updated successfully, but these errors were encountered: