Ensure protocol is set when rendering stations view #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM and definitely should be fixed, but could you elaborate on how this affects wiring it up with telly (I'm not familiar with it)? ✌️ |
|
Not at all, my PR text was probably misleading .. thought the fix was so trivial that I forgot to elaborate on the fix :) Just wanted to say thank you, what I used it for and how I got to fixing this bug. It's completely unrelated to telly, I just noticed the bug while playing around and was annoyed enough to fix it (although it can obviously be worked around by setting |
|
Ah, now I got it. Thanks for catching that! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this nice project!
.. with it I could wire up MagentaTV through https://github.com/tellytv/telly to Plex Media Server :)