Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add m3u playlist download #87

Merged
merged 4 commits into from
Dec 17, 2020
Merged

Add m3u playlist download #87

merged 4 commits into from
Dec 17, 2020

Conversation

Tereius
Copy link
Contributor

@Tereius Tereius commented Dec 15, 2020

No description provided.

Copy link
Owner

@n-thumann n-thumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution! That look´s like a useful feature! 👏
I'd prefer removing the simple parameter, because it isn't accessible from the UI and I think it isn't much of a benefit to not include the channel number, title and image in the M3U. Of course it takes up three times more space, but that should be acceptable as we're talking kilobytes here 😊

src/routes/station.ts Outdated Show resolved Hide resolved
src/providers/m3u.ts Outdated Show resolved Hide resolved
src/providers/m3u.ts Outdated Show resolved Hide resolved
@Tereius
Copy link
Contributor Author

Tereius commented Dec 15, 2020

I agree. Thank you for merging.

Tereius and others added 3 commits December 16, 2020 16:16
Remove "simple" m3u playlist

Co-authored-by: Nicolas Thumann <[email protected]>
Remove "simple" m3u playlist

Co-authored-by: Nicolas Thumann <[email protected]>
Remove "simple" m3u playlist

Co-authored-by: Nicolas Thumann <[email protected]>
@n-thumann n-thumann changed the base branch from master to dev December 17, 2020 16:48
@n-thumann n-thumann merged commit 5545b5a into n-thumann:dev Dec 17, 2020
@n-thumann
Copy link
Owner

Merged and pushed a new release ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants