Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax nokogiri dependency from 1.11.0 to 1.10.10 #10

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Aug 1, 2022

This is required to support Ruby 2.4.

Closes #9

Signed-off-by: Takuya Noguchi [email protected]

This is required to support Ruby 2.4

Signed-off-by: Takuya Noguchi <[email protected]>
@tnir tnir force-pushed the 9-relax-nokogiri-for-ruby-2.4 branch from 6719b62 to 7d38e0e Compare August 1, 2022 03:54
@tnir tnir self-assigned this Aug 1, 2022
@tnir tnir added the bug Something isn't working label Aug 1, 2022
Copy link
Contributor Author

@tnir tnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tnir tnir merged commit 60200dc into master Aug 1, 2022
@tnir tnir deleted the 9-relax-nokogiri-for-ruby-2.4 branch August 1, 2022 03:58
@tnir
Copy link
Contributor Author

tnir commented Aug 1, 2022

I do not know who needs Ruby 2.4 support.

@tnir tnir added this to the v0.10.1 milestone Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make test for Ruby 2.4 better
1 participant