-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap remaining ES6 classes in GObject.registerClass(). #78
Conversation
Maybe I need to change formatting a bit? |
hmm idk, is that a fix? IT still dosen't work for me. |
seems like the |
Do you mean "can't use 'in' operator to check for presence of 'schema' in 'org.gnome.shell…"? With my gjs 1.58.2, I had to change from 'constructor' to 'init' in Settings class. |
@ettavolt I am trying your branch, usually, I think TypeError: cannot use 'in' operator to search for 'schema' in 'org.gnome.shell....'
let settings = new Settings(WsMatrix.metadata['settings-schema']); |
@ViggoGaming can you please show the error that you got? |
What? Same code, but works in one place and not another? |
my bad, seems like not all files were pulled from your branch for some reason. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks just like the fix suggested here. Can you please revert the indentation to what it was before? The actual code changes are fine.
Wrap remaining ES6 classes in GObject.registerClass(). Override Gio.Settings._init instead of constructor.
Now it's
And GitHub shows less changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Override Gio.Settings._init instead of constructor.
Closes #77.