Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement complete switcher caching #27

Merged
merged 3 commits into from
May 13, 2019
Merged

Conversation

ebeem
Copy link
Collaborator

@ebeem ebeem commented May 6, 2019

as discussed in #24 and #26
this is the caching part that we can't guarantee its stability

note: this feature is disabled by default, and must be enabled from the preferences.

Copy link
Owner

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed the setting to "cache popup" instead of "cache switcher" because it's already called popup in the settings. Also, the settings widget is only active if thumbnails are enabled, as the caching only affects the thumbnails popup.

@mzur
Copy link
Owner

mzur commented May 13, 2019

I observed one weird thing: When I added a log('HIDE') to check if the hide/destroy works correctly, it would print HIDE whenever I switched windows with Alt+Tab. Apparently this action also calls destroy for the switcher popup if it still exists but I don't know where and why. Do you have an idea why this is? I guess we can merge this anyway but still...

@ebeem
Copy link
Collaborator Author

ebeem commented May 13, 2019

I checked this before, the app switcher (alt+tab) and workspaces switcher do NOT overlap. I think you can see this in the method _startSwitcher in windowManager.js if I am not mistaken

        /* prevent a corner case where both popups show up at once */
        if (this._workspaceSwitcherPopup != null)
            this._workspaceSwitcherPopup.destroy();

@mzur
Copy link
Owner

mzur commented May 13, 2019

I see. This explains why destroy is called each time Alt+Tab is used and the switcher popup is hidden.

@mzur mzur merged commit d02b408 into mzur:master May 13, 2019
@mzur
Copy link
Owner

mzur commented Aug 7, 2019

@ebeem Would you be interested in getting write access to this repository? I expect to have almost no time for maintenance in the next couple of months. It would be good to know that somebody else could also handle bug fixes or new issues. I'm not asking you to take over this repository, only to help with maintenance when I'm unresponsive and if you are willing and have the time 😉

@ebeem
Copy link
Collaborator Author

ebeem commented Aug 7, 2019

@mzur Sure, I might not have time to implement new features for now, but since I rely on this extension a lot, I am ready to fix critical bugs and try my best to make this extension compatible with the latest stable version of GNOME

@mzur
Copy link
Owner

mzur commented Aug 7, 2019

Great, thanks! I wasn't talking about new features, too, as I would like to still have a say in that in the future 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants