Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added env. variables that are used in the Makefiles of projects like esp... #2

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

slaff
Copy link

@slaff slaff commented Feb 8, 2015

...httpd.

Slavey Karadzhov added 4 commits February 8, 2015 21:25
@@ -21,7 +21,19 @@ fi

cd /opt/Espressif/crosstool-NG

function gitsha() { git show --format=%H | head -1; }
# Git complains if these values are not set
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think this git config is necessary -- it's needed for commits, but we're only doing clones and pulls

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the same but without it the provisioning was failing. You can test it by getting this file and then running:

vagrant provision

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants