Skip to content

Commit

Permalink
chore: change deprecation versions post 4.0 (apache#28019)
Browse files Browse the repository at this point in the history
  • Loading branch information
eschutho authored Apr 22, 2024
1 parent cddcff2 commit 83fedcc
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion superset/views/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ def generate_download_headers(


def deprecated(
eol_version: str = "4.0.0",
eol_version: str = "5.0.0",
new_target: str | None = None,
) -> Callable[[Callable[..., FlaskResponse]], Callable[..., FlaskResponse]]:
"""
Expand Down
4 changes: 2 additions & 2 deletions superset/views/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ def generate_json(
@permission_name("explore_json")
@expose("/explore_json/data/<cache_key>", methods=("GET",))
@check_resource_permissions(check_explore_cache_perms)
@deprecated(eol_version="4.0.0")
@deprecated(eol_version="5.0.0")
def explore_json_data(self, cache_key: str) -> FlaskResponse:
"""Serves cached result data for async explore_json calls
Expand Down Expand Up @@ -259,7 +259,7 @@ def explore_json_data(self, cache_key: str) -> FlaskResponse:
)
@etag_cache()
@check_resource_permissions(check_datasource_perms)
@deprecated(eol_version="4.0.0")
@deprecated(eol_version="5.0.0")
def explore_json(
self, datasource_type: str | None = None, datasource_id: int | None = None
) -> FlaskResponse:
Expand Down
4 changes: 2 additions & 2 deletions superset/views/key_value.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def ensure_enabled(self) -> None:
@event_logger.log_this
@has_access_api
@expose("/store/", methods=("POST",))
@deprecated(eol_version="4.0.0")
@deprecated(eol_version="5.0.0")
def store(self) -> FlaskResponse:
try:
value = request.form.get("data")
Expand All @@ -58,7 +58,7 @@ def store(self) -> FlaskResponse:
@event_logger.log_this
@has_access_api
@expose("/<int:key_id>/", methods=("GET",))
@deprecated(eol_version="4.0.0")
@deprecated(eol_version="5.0.0")
def get_value(self, key_id: int) -> FlaskResponse:
try:
kv = db.session.query(models.KeyValue).filter_by(id=key_id).scalar()
Expand Down

0 comments on commit 83fedcc

Please sign in to comment.