Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converter Inheritance Support #385

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Converter Inheritance Support #385

merged 3 commits into from
Jun 19, 2024

Conversation

Soyvolon
Copy link
Contributor

Changes

  • Added additional constructor with parameter (param Assembly[] additionalAssemblies) to the Converter constructor with support for custom converters and converters that inherit from existing converters.
  • Changed all private readonly fields in Converter to protected readonly
  • Changed all public methods in Converter to public virtual
  • Added test class/case for testing the constructor.

Issues

Closes #384

@Soyvolon Soyvolon mentioned this pull request Mar 26, 2024
Closed
@mysticmind mysticmind marked this pull request as ready for review June 19, 2024 04:55
@mysticmind mysticmind merged commit 2e3d52f into mysticmind:master Jun 19, 2024
@mysticmind mysticmind changed the title [Draft] Converter Inheritance Support Converter Inheritance Support Jun 19, 2024
@mysticmind
Copy link
Owner

@Soyvolon @abounds-fsp I managed to run through the changes and merge the same 👍

@mysticmind mysticmind modified the milestone: 4.6.0 Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

Update Classes to Support Customization via Inheritance
3 participants
@Soyvolon @mysticmind @abounds-fsp