Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: add ESLint core Node.js and CommonJS rules #206

Merged
merged 12 commits into from
Feb 18, 2020
Merged

Update: add ESLint core Node.js and CommonJS rules #206

merged 12 commits into from
Feb 18, 2020

Conversation

kaicataldo
Copy link
Contributor

@kaicataldo kaicataldo commented Feb 10, 2020 •
edited
Loading

As discussed in eslint/eslint#12835, this PR ports over ESLint's core Node.js and CommonJS rules to this plugin. I've tried to follow the style I see in this repo, but please let me know if I missed anything. Thanks!

Questions:

  1. Do all the author attributions look correct?
  2. Do the rule categories seem correct?
  3. Did I miss anything?

@kaicataldo kaicataldo force-pushed the deprectea-core-node-rules branch from ae6f2be to be2442c Compare February 10, 2020 17:49
This was referenced Feb 10, 2020
Closed
Merged
mysticatea
mysticatea requested changes Feb 11, 2020
View reviewed changes
Copy link
Owner

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for working on this!

Almost LGTM, but I have a few requests.

docs/rules/no-buffer-constructor.md Outdated Show resolved Hide resolved
docs/rules/no-restricted-modules.md Outdated Show resolved Hide resolved
lib/rules/no-mixed-requires.js Outdated Show resolved Hide resolved
lib/rules/callback-return.js Outdated Show resolved Hide resolved
@kaicataldo kaicataldo force-pushed the deprectea-core-node-rules branch from f93ba69 to ae4e32a Compare February 14, 2020 23:56
mysticatea
mysticatea approved these changes Feb 16, 2020
View reviewed changes
Copy link
Owner

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@kaicataldo
Copy link
Contributor Author

Anything else you need from me to land this?

@mysticatea mysticatea merged commit 8788a11 into mysticatea:master Feb 18, 2020
@mysticatea
Copy link
Owner

Thank you for your work! I will land this next weekend.

@kaicataldo kaicataldo deleted the deprectea-core-node-rules branch February 23, 2020 03:05
brettz9 pushed a commit to brettz9/eslint-plugin-node that referenced this pull request Jul 24, 2024
@coderaiser
fix(prefer-node-protocol): continue on version range check (mysticate…
14d2ea9 
…a#206)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysticatea mysticatea mysticatea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaicataldo @mysticatea