First stab at fixing /nearest #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracos
force-pushed
the
nearest_no_longer_knackered
branch
from
c5fcb45
to
a1656db
Compare
The nearest postcode lookup performance reduced dramatically when tried with Postgres 9.6 and PostGIS 2.3. This commit updates the query to use the ‘<->’ centroid distance operator instead, which makes better use of the geoindex and is much faster to execute. Handily, the work @dracos did to introduce the TrigramDistance function into Django 1.10 was easily adaptable for this purpose, as the operator used is the same.
dracos
force-pushed
the
nearest_no_longer_knackered
branch
from
a1656db
to
4d15041
Compare
|
Tweaked after merge to transform to 4326. And to fetch 100 rows and take actual closest, as we're using geometry not geography. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something about the recent move to Postgres 9.6 and PostGIS 2.3 caused
the /nearest query to take much longer than 10 seconds to complete.
This commit updates the query to use the ‘<->’ centroid distance operator
instead, which makes better use of the geoindex and is much faster to
execute.
Handily the work @dracos did to introduce the TrigramDistance function
into Django 1.10 was easily adapted for this purpose, as it uses the
same operator.
This needs a bit of tidying and refactoring before merging really.