Fix display of Geometry object in admin. #273
Conversation
dracos
force-pushed
the
272-geometry-admin-error
branch
from
c67e0c8
to
71ab748
Compare
dracos
force-pushed
the
272-geometry-admin-error
branch
from
71ab748
to
6b5b1ee
Compare
| @@ -333,7 +333,7 @@ class Meta: | |||
| verbose_name_plural = 'geometries' | |||
|
|
|||
| def __str__(self): | |||
| return '%s, polygon %d' % (self.area, self.id) | |||
| return '%s, polygon %d' % (smart_text(self.area), self.id) | |||
There was a problem hiding this comment.
Q: Why didn’t you use u'' as an easier way to fix this?
A: Django 1.8, still supported, still supports Python 3.2, therefore so do we. u'' was only re-added in 3.3.
|
Looks good, but looking at a the models.py this is in, there are a few other models that take some text either from a data source or the user and return it from |
|
Any text coming from a CharField will be a Unicode string, so they’re all already covered (I think I did check them all, double check helpful :) ); the reason this issue arose is because the Geometry |
|
aha, gotcha. I double-checked and I think you're right |
Fixes #272.