Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 'add_ons_to_gss' command to support CSVReader for Python 2 #244

Closed
wants to merge 1 commit into from
Closed

Update 'add_ons_to_gss' command to support CSVReader for Python 2 #244

wants to merge 1 commit into from

Commits on Jun 28, 2016

  1. Update 'add_ons_to_gss' command to support CSVReader for Python 2 

    The command would error when running with Python 2.7, failing to recognise the Welsh characters `ô` and `â` with "UnicodeEncodeError: 'ascii' codec can't encode character u'\xf4' in position 16: ordinal not in range(128)". This is due to `csv.reader` changing between Python 2 and 3 - in 2 it expected a file-like object on which next() would return raw bytes, and in 3 one which would return unicode strings. We opt to explicitly check which version of Python is running and run the old code for < Python 3.

We also stop assigning `name` for the 'code-change.csv' as it is not used anywhere else in the script and the encoding probably won't be handled correctly with Python 2. We stop assigning `type` and `name` for 'missing-codes.csv' for the same reasons.
    @davidbasalla
    davidbasalla committed Jun 28, 2016
    Configuration menu
    Copy the full SHA
    15b0fdf View commit details
    Browse the repository at this point in the history