29 uk theme analytics #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Account related styles are now in _accounts.scss, button styles are in _buttons.scss, and variables in _variables.scss
Pricing page signup links will pre-fill plan on signup form
Do not ask for credit card with the free option, but still create a subscription so things are more consistent. Allow plan to be provided in URL (already present on pricing page).
Includes better error styles on the signup form (building on the javascript error handling added in 2e4f97a), better error/alert styles for logged-in users, and more consistent button styling.
Better login/your account links.
This should work with regard to asking/not asking for payment details if we don't/do already have them. Remove coupon by deleting subscription’s discount.
The `ui-refresh` branch of mapit core now includes most of the base styles and header/body/footer templates. So there’s no need for them to be duplicated in here. `bin/mapit_make_css` has also been updated to pull the new core mapit styles into the mapit.mysociety.org Sass pipeline. Until the `ui-refresh` branch is merged into mapit core, you’ll need to manually switch to the branch in the django-mapit repo to see all of this working.
* Ugrade to Universal Analytics. * Track user authentication as custom dimension 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires mysociety/mapit#283 and mysociety/mapit#284.