Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List and tuple different types #27

Merged
merged 1 commit into from
Mar 4, 2018
Merged

List and tuple different types #27

merged 1 commit into from
Mar 4, 2018

Conversation

silentsokolov
Copy link
Contributor

List -> Array and Tuple -> Tuple like psycopg2.

@coveralls
Copy link

coveralls commented Feb 19, 2018

Coverage Status

Coverage increased (+0.004%) to 95.526% when pulling c99b1b1 on silentsokolov:feat-tuple into a3a2651 on mymarilyn:master.

@xzkostyan
Copy link
Member

Hi.

Cool, but it's partial tuple support.

Query SELECT (1, 2) will fail on types parsing. For full tuple support we need to implement TupleColumn like ArrayColumn.

Yup, it's a little bit complicated. I haven't take a deep look into Tuple's internals in CH yet.

Anyway, I can merge this PR as is later.

@xzkostyan xzkostyan merged commit e367ef3 into mymarilyn:master Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants