Implement Client as context manager #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify usage of the Client class by adding `__enter__` and `__exit__` methods, with the latter closing any established connection to the server.
wlhjason
commented
Jul 20, 2021
| def __enter__(self): | ||
| return self | ||
|
|
||
| def __exit__(self, exc_type, exc_val, exc_tb): |
There was a problem hiding this comment.
No return value so that exceptions are propagated.
wlhjason
commented
Jul 20, 2021
|
|
||
|
|
||
| class ClientFromUrlTestCase(TestCase): | ||
| class ClientFromUrlTestCase(BaseTestCase): |
There was a problem hiding this comment.
Not sure if this is the best way to get a Client instance to test with?
wlhjason
commented
Jul 20, 2021
| @@ -90,6 +90,12 @@ def __init__(self, *args, **kwargs): | |||
| self.reset_last_query() | |||
| super(Client, self).__init__() | |||
|
|
|||
| def __enter__(self): | |||
| return self | |||
There was a problem hiding this comment.
Could run a dummy query like SELECT 1 here to test the server/client settings (check for unknown settings if settings_is_important)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify usage of the Client class by adding
__enter__and__exit__methods, with the latter closing any established connection to the server.