Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zen ZSH #269

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Zen ZSH #269

wants to merge 14 commits into from

Conversation

0blivi0nis
Copy link

This pull requests holds a few upgrades to ZSH & updates to the packages installed.

  1. Removed oh-my-zsh & starship.

    • With the current setup, the setup installs both starship and oh-my-posh. I believe having 2 different prompts is bloat and believe in only keeping oh-my-posh since its superior IMO. Along with this, oh-my-zsh is unnecessary and slows down boot times and the same functions can be achieved manually.
  2. Updates to packages

    • general.sh: Removed starship, zsh-completion (replaced in 3.), trizen & pacseek (moved to optional.sh). Added rsync since its a dependency for ./ml4w-hyprland-setup. Updated oh-my-posh to oh-my-posh-bin
    • hyprland.sh: Fixed grimblast package by changing it to grimblast-git
  3. Native Plugin Handling in ZSH

    • With the removal of oh-my-zsh, I have built in a way to install plugins directly into 20-customizations. The section under # Plugins is pretty similar to the changes in ~/.config/ml4w/scripts/shell.sh. Initially, this scripts installs all the plugins oh-my-zsh installed along with 4 additional plugins, colored-man-pages, extract, command-not-found, and you-should-use. All of the plugins are pulled directly from source during the post install script.
    • In the 20-customization file, similar commands are ran to check for the plugins, install if missing or source if they already exists there. In order to add new plugins just copy the last plugins if statement and replace with link with the new plugins link and the name of the files.

…e of dotfiles dependency and updated oh-my-posh to oh-my-posh-bin in general.sh. Updated grimblast to grimblast-git in hyprland.sh. Added trizen and pacseek to optional.sh.
…bash and zsh to use posh and addded a variable for built in oh-my-posh themes. Removed oh-my-zsh since it slows down boot times and is not really needed. Added some basic plugins in the plugin folder. The post install shell script still installs all the previous plugins used by oh-my-zsh and also install zsh-completions but sources it manually removing the need for oh-my-zsh completely.
…s to shell.sh to install the plugins directly from source if the user chooses zsh.
fixed gaps in script
@0blivi0nis
Copy link
Author

Forgot to mention, I have tried installing directly from my branch on 2 different devices and the setup ran smoothly. Currently, even on ml4w-dotfiles:main, the rsync package is missing and oh-my-posh and grimblast are outdated. Also trizen and pacseek should both be optional imo since they are not really required.

@0blivi0nis 0blivi0nis marked this pull request as draft September 26, 2024 03:54
@0blivi0nis 0blivi0nis marked this pull request as ready for review September 26, 2024 03:54
@mylinuxforwork mylinuxforwork added enhancement New feature or request to be confirmed Issue is currently under review and has not been released labels Sep 27, 2024
0blivi0nis and others added 4 commits September 28, 2024 17:46
Instead of checking for installed AUR helpers liek yay and paru and then deciding what to do, this script initially asks the user what their preferred AUR helper is, it then checks if the chosen helper is installed. If not, the script then installs the chosen AUR helper and cleans up after it self at then end.
@ZeroEcks
Copy link

ZeroEcks commented Oct 3, 2024

I like a lot of stuff in this PR, would it be possible to add some support for "aurto" or other non-wrapper helpers in this PR (even as an argument or advanced option?). I believe we would just have to set pacman as a potential aur helper, and tell the user to ensure all required packages are installed? It's not the most user friendly though, but would be a nice hack. Otherwise I am happy to just edit that in as an option.

This would also add support for users who are using pacman repos that already have all the required AUR packages (potentially chaotic-aur, unsure if this has all the required packages at this moment however)

@0blivi0nis
Copy link
Author

@ZeroEcks An advanced option where it sets the aur helper to pacman and warns user the user about all the required packages from the files should be pretty simple. I'll test it out and push it to this PR if it works properly.

@0blivi0nis
Copy link
Author

@mylinuxforwork Have you had the chance to checkout the custom aur helper?

@mylinuxforwork
Copy link
Owner

@mylinuxforwork Have you had the chance to checkout the custom aur helper?

Not yet. I am currently working on the maintenance release of 2.9.6.2 with important updates of the base installation. But will definitely check for 2.9.7

I will come back to you as soon as possible.

@mylinuxforwork mylinuxforwork added this to the v2.9.7 milestone Oct 4, 2024
@0blivi0nis
Copy link
Author

@ZeroEcks i have made a new branch aur. Can you check it out and see if it works?

@ZeroEcks
Copy link

Sorry mate, I don't really have time to test at the moment, however you can emulate it by exporting the packages (.tar.xz files), then installing them with pacman -U *.tar.xz, it should work fine from there with the package manager set to pacman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request to be confirmed Issue is currently under review and has not been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants