This repository has been archived by the owner on Mar 23, 2021. It is now read-only.
main: fix bug with major version >= 2 being installed to wrong target #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myitcv
force-pushed
the
fix_major_version_break
branch
5 times, most recently
from
aa83761 to
773807a
Compare
We previously had a test that ensure the cache path of a major package >= 2 was correct, but this failed to ensure the installed binary had the right target name. Fix the test and fix the bug. Fixes #82
myitcv
force-pushed
the
fix_major_version_break
branch
from
773807a to
cae8a95
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously had a test that ensure the cache path of a major package
Fix the test and fix the bug.
Fixes #82