-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variuos small changes #42
Conversation
Thank you for your PR but...
Thank you. But I have do close this. |
@BenjaminAbt Sorry, I missed the explanation block:
|
You are active in the open source scene, so you should know that direct PR without discussion is usually not a good idea :-) You don't need an extra NuGet package for deterministic builds. There has been an MSBuild parameter for years, and now also a dotnet pack parameter. We already have this with other NuGet enhancements on our agenda.
.NET 7 is still more used than .NET 8 today tho
watch the contents again, they are not default
thats not how the global.json works tho |
<FrameworkReference Include="Microsoft.AspNetCore.App" />
. But this doesn't make sense in the main library, soHttpContextExtensions.cs
has been moved to the AspNet library.