Configure travis for php7.3 and update scripts #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnapoli
reviewed
Oct 29, 2018
| @@ -17,11 +18,12 @@ cache: | |||
| - $HOME/.composer/cache | |||
|
|
|||
| before_script: | |||
| - travis_retry composer install -n | |||
| - travis_retry composer self-update | |||
There was a problem hiding this comment.
To use actual version of composer
There was a problem hiding this comment.
Why is it necessary? I'm sorry but if there's no reason to waste time on that then we shouldn't do it.
mnapoli
reviewed
Oct 29, 2018
| @@ -17,11 +18,12 @@ cache: | |||
| - $HOME/.composer/cache | |||
|
|
|||
| before_script: | |||
| - travis_retry composer install -n | |||
| - travis_retry composer self-update | |||
| - travis_retry composer install --no-interaction --prefer-source | |||
There was a problem hiding this comment.
travis will download current sources directly from git without any questions
There was a problem hiding this comment.
I'm not asking what it does, I'm asking why are you changing the build to do that? What advantages does it provide?
Every pull request should explain the changes it contains. Don't expect me to guess.
|
I don't want to wait on this PR sorry, I have too many projects to maintain. I'll do it myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.