Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore limit based on direction #5

Closed

Conversation

NomarCub
Copy link

@NomarCub NomarCub commented Mar 1, 2022

This makes it so that panes don't expand when making the window narrower, and don't collapse when making the window wider. A potential solution to #2. I also updated the config files to the latest from the Obsidian Sample Plugin.

@NomarCub
Copy link
Author

@mybuddymichael if you have the time I'd appreciate if you took a look at this.

@mybuddymichael
Copy link
Owner

There seems to be a decent number of changes that are unrelated to the problem stated in the PR text. As it is, I'm not going to accept this PR in its current form. If you want to reduce the code changes to exactly and only those that solve the problem stated in the PR, I can take a look again. If there are other problems with this repository, I encourage you to make separate PRs for those.

@NomarCub
Copy link
Author

NomarCub commented Apr 5, 2022

Hi!
I reduced the code changes.

@NomarCub
Copy link
Author

@mybuddymichael it's been a while, would you take a look at this?

@NomarCub
Copy link
Author

NomarCub commented Jun 4, 2022

@mybuddymichael Please accept this PR. I'm gonna have to make a fork and submit it to community plugins to get this feature otherwise.

@NomarCub
Copy link
Author

NomarCub commented Aug 1, 2022

It's been a while. I made a fork that I'm in the process of adding to community plugins here: obsidianmd/obsidian-releases#1063

Would you be open to transfering the existing plugin entry over to my repo? Or adding me as a maintainer to this repo? Or transferring this repo to me? I just want the PR to be available to the public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants