Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deleting timer task results automatically #253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

my8100
Copy link
Owner

@my8100 my8100 commented Jan 19, 2025

No description provided.

@coveralls
Copy link

coveralls commented Jan 19, 2025

Pull Request Test Coverage Report for Build 47430779-876a-4382-ae1a-ac1ab581c2c8

Details

  • 33 of 57 (57.89%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 85.481%

Changes Missing Coverage Covered Lines Changed/Added Lines %
scrapydweb/utils/check_app_config.py 20 21 95.24%
scrapydweb/views/overview/tasks.py 4 27 14.81%
Totals Coverage Status
Change from base Build 589177c1-680f-44b6-8516-266da32fda8b: -0.4%
Covered Lines: 3503
Relevant Lines: 4098

💛 - Coveralls

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 57.89474% with 24 lines in your changes missing coverage. Please review.

Project coverage is 85.48%. Comparing base (45a440b) to head (9568dda).

Files with missing lines Patch % Lines
scrapydweb/views/overview/tasks.py 14.81% 23 Missing ⚠️
scrapydweb/utils/check_app_config.py 95.23% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
- Coverage   85.87%   85.48%   -0.40%     
==========================================
  Files          34       34              
  Lines        4042     4098      +56     
==========================================
+ Hits         3471     3503      +32     
- Misses        571      595      +24     
Files with missing lines Coverage Δ
scrapydweb/default_settings.py 100.00% <100.00%> (ø)
scrapydweb/run.py 0.00% <ø> (ø)
scrapydweb/views/baseview.py 89.69% <100.00%> (+0.10%) ⬆️
scrapydweb/views/system/settings.py 98.82% <100.00%> (+0.04%) ⬆️
scrapydweb/utils/check_app_config.py 83.17% <95.23%> (+0.86%) ⬆️
scrapydweb/views/overview/tasks.py 90.44% <14.81%> (-7.69%) ⬇️

@my8100
Copy link
Owner Author

my8100 commented Jan 20, 2025

Fix #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants