-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #910]🚀Implement mq producer other methods-2🚀 #915
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe recent changes introduce significant enhancements to the RocketMQ client library, particularly around Changes
Sequence Diagram(s)sequenceDiagram
participant Producer
participant AdminImpl
participant ClientAPI
Producer->>AdminImpl: fetch_publish_message_queues(topic)
AdminImpl->>ClientAPI: get_topic_route_info(topic)
ClientAPI-->>AdminImpl: return message queues
AdminImpl-->>Producer: return message queues
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥 |
🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #915 +/- ##
==========================================
- Coverage 24.16% 24.16% -0.01%
==========================================
Files 351 351
Lines 28279 28284 +5
==========================================
Hits 6834 6834
- Misses 21445 21450 +5 ☔ View full report in Codecov by Sentry. |
Which Issue(s) This PR Fixes(Closes)
Fixes #910
Brief Description
How Did You Test This Change?
Summary by CodeRabbit
New Features
MQAdminImpl
to enhance operation management.DefaultMQProducer
to modify its state during the fetching of publish message queues, enhancing functionality.Bug Fixes
Refactor