Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #76] ✨ Namesrv supports get all topic list from name server(request code 206) #81

Merged
merged 1 commit into from
Jan 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ Feature list:
| Get broker cluster info | 106 | :sparkling_heart: :white_check_mark: | |
| Wipe write perm of boker | 205 | :sparkling_heart: :white_check_mark: | |
| Add write perm of brober | 327 | :sparkling_heart: :white_check_mark: | |
| Get all topic list from name server | 206 | :broken_heart: :x: | |
| Get all topic list from name server | 206 | :sparkling_heart: :white_check_mark: | |
| Delete topic in name server | 216 | :broken_heart: :x: | |
| Register topic in name server | 217 | :broken_heart: :x: | |
| Get topics by cluster | 224 | :broken_heart: :x: | |
Expand Down
34 changes: 17 additions & 17 deletions rocketmq-namesrv/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,30 +14,30 @@ Feature list:

- **Perfect support**: :sparkling_heart: :white_check_mark:

| Feature | request code | Support | remark |
| -------------------------------------- | ------------ | -------------- | ------ |
| Put KV Config | 100 | :sparkling_heart: :white_check_mark: | |
| Feature | request code | Support | remark |
| -------------------------------------- | ------------ |--------------------------------------|--------|
| Put KV Config | 100 | :sparkling_heart: :white_check_mark: | |
| Get KV Config | 101 | :sparkling_heart: :white_check_mark: | |
| Delete KV Config | 102 | :sparkling_heart: :white_check_mark: | |
| Get kv list by namespace | 219 | :broken_heart: :x: | |
| Query Data Version | 322 | :sparkling_heart: :white_check_mark:| |
| Register Broker | 103 | :heart: :white_check_mark: | |
| Unregister Broker | 104 | :broken_heart: :x: | |
| Get kv list by namespace | 219 | :broken_heart: :x: | |
| Query Data Version | 322 | :sparkling_heart: :white_check_mark: | |
| Register Broker | 103 | :heart: :white_check_mark: | |
| Unregister Broker | 104 | :broken_heart: :x: | |
| Broker Heartbeat | 904 | :sparkling_heart: :white_check_mark: | |
| Get broker member_group | 901 | :sparkling_heart: :white_check_mark: | |
| Get broker cluster info | 106 | :sparkling_heart: :white_check_mark: | |
| Wipe write perm of boker | 205 | :sparkling_heart: :white_check_mark: | |
| Add write perm of brober | 327 | :sparkling_heart: :white_check_mark: | |
| Get all topic list from name server | 206 | :broken_heart: :x: | |
| Delete topic in name server | 216 | :broken_heart: :x: | |
| Register topic in name server | 217 | :broken_heart: :x: | |
| Get topics by cluster | 224 | :broken_heart: :x: | |
| Get system topic list from name server | 304 | :broken_heart: :x: | |
| Get unit topic list | 311 | :broken_heart: :x: | |
| Get has unit sub topic list | 312 | :broken_heart: :x: | |
| Get has unit sub ununit topic list | 313 | :broken_heart: :x: | |
| Update name server config | 318 | :broken_heart: :x: | |
| Get name server config | 318 | :broken_heart: :x: | |
| Get all topic list from name server | 206 | :sparkling_heart: :white_check_mark: | |
| Delete topic in name server | 216 | :broken_heart: :x: | |
| Register topic in name server | 217 | :broken_heart: :x: | |
| Get topics by cluster | 224 | :broken_heart: :x: | |
| Get system topic list from name server | 304 | :broken_heart: :x: | |
| Get unit topic list | 311 | :broken_heart: :x: | |
| Get has unit sub topic list | 312 | :broken_heart: :x: | |
| Get has unit sub ununit topic list | 313 | :broken_heart: :x: | |
| Update name server config | 318 | :broken_heart: :x: | |
| Get name server config | 318 | :broken_heart: :x: | |

## Getting Started

Expand Down
15 changes: 15 additions & 0 deletions rocketmq-namesrv/src/processor/default_request_processor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ impl RequestProcessor for DefaultRequestProcessor {
Some(RequestCode::GetBrokerClusterInfo) => self.get_broker_cluster_info(request),
Some(RequestCode::WipeWritePermOfBroker) => self.wipe_write_perm_of_broker(request),
Some(RequestCode::AddWritePermOfBroker) => self.add_write_perm_of_broker(request),
Some(RequestCode::GetAllTopicListFromNameserver) => {
self.get_all_topic_list_from_nameserver(request)
}

_ => RemotingCommand::create_response_command_with_code(
RemotingSysResponseCode::SystemError,
Expand Down Expand Up @@ -348,6 +351,18 @@ impl DefaultRequestProcessor {
AddWritePermOfBrokerResponseHeader::new(add_topic_cnt),
)))
}

fn get_all_topic_list_from_nameserver(&mut self, _request: RemotingCommand) -> RemotingCommand {
let rd_lock = self.route_info_manager.read();
if rd_lock.namesrv_config.enable_all_topic_list {
let topics = rd_lock.get_all_topic_list();
drop(rd_lock); //release lock
return RemotingCommand::create_response_command()
.set_body(Some(Bytes::from(topics.encode())));
}
RemotingCommand::create_response_command_with_code(RemotingSysResponseCode::SystemError)
.set_remark(Some(String::from("disable")))
}
}

fn extract_register_topic_config_from_request(
Expand Down
14 changes: 14 additions & 0 deletions rocketmq-namesrv/src/route/route_info_manager.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ use rocketmq_remoting::{
protocol::{
body::{
broker_body::{broker_member_group::BrokerMemberGroup, cluster_info::ClusterInfo},
topic::topic_list::TopicList,
topic_info_wrapper::topic_config_wrapper::TopicConfigAndMappingSerializeWrapper,
},
header::namesrv::brokerid_change_request_header::NotifyMinBrokerIdChangeRequestHeader,
Expand Down Expand Up @@ -675,4 +676,17 @@ impl RouteInfoManager {
}
topic_cnt
}

pub(crate) fn get_all_topic_list(&self) -> TopicList {
let topics = self
.topic_queue_table
.keys()
.cloned()
.collect::<Vec<String>>();

TopicList {
topic_list: topics,
broker_addr: None,
}
}
}
1 change: 1 addition & 0 deletions rocketmq-remoting/src/protocol/body.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,5 @@

pub mod broker_body;
pub mod kv_table;
pub mod topic;
pub mod topic_info_wrapper;
18 changes: 18 additions & 0 deletions rocketmq-remoting/src/protocol/body/topic.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

pub mod topic_list;
30 changes: 30 additions & 0 deletions rocketmq-remoting/src/protocol/body/topic/topic_list.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
use serde::{Deserialize, Serialize};

use crate::protocol::RemotingSerializable;

#[derive(Debug, Clone, Serialize, Deserialize, Default)]
#[serde(rename_all = "camelCase")]
pub struct TopicList {
pub topic_list: Vec<String>,
pub broker_addr: Option<String>,
}

impl RemotingSerializable for TopicList {
type Output = TopicList;
}
Loading