Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #441]🔥Improving PutMessageHook logic🚀 #442

Merged
merged 1 commit into from
Jun 7, 2024
Merged

[ISSUE #441]🔥Improving PutMessageHook logic🚀 #442

merged 1 commit into from
Jun 7, 2024

Conversation

mxsm
Copy link
Owner

@mxsm mxsm commented Jun 7, 2024

Which Issue(s) This PR Fixes(Closes)

Fixes #441

Brief Description

How Did You Test This Change?

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 1.47059% with 67 lines in your changes missing coverage. Please review.

Project coverage is 21.81%. Comparing base (3d56efb) to head (42682c9).
Report is 1 commits behind head on main.

Files Patch % Lines
rocketmq-store/src/log_file/commit_log.rs 0.00% 20 Missing ⚠️
...q-store/src/message_store/default_message_store.rs 0.00% 13 Missing ⚠️
rocketmq-broker/src/broker_runtime.rs 0.00% 10 Missing ⚠️
...cketmq-broker/src/hook/check_before_put_message.rs 0.00% 9 Missing ⚠️
...-broker/src/hook/batch_check_before_put_message.rs 0.00% 8 Missing ⚠️
rocketmq-broker/src/util/hook_utils.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
+ Coverage   21.59%   21.81%   +0.21%     
==========================================
  Files         212      216       +4     
  Lines       14577    14898     +321     
==========================================
+ Hits         3148     3250     +102     
- Misses      11429    11648     +219     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxsm mxsm merged commit ccbcfcf into main Jun 7, 2024
8 of 9 checks passed
@mxsm mxsm deleted the en-441 branch June 7, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Improving PutMessageHook logic
4 participants