Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #417]✨Implement message persistence to disk during transmission🚀 #418

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

mxsm
Copy link
Owner

@mxsm mxsm commented Jun 2, 2024

Which Issue(s) This PR Fixes(Closes)

Fixes #417

Brief Description

How Did You Test This Change?

Copy link
Contributor

@SpaceOneT SpaceOneT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SpaceXCN SpaceXCN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jun 2, 2024

Codecov Report

Attention: Patch coverage is 37.54045% with 193 lines in your changes are missing coverage. Please review.

Project coverage is 21.07%. Comparing base (f3a1058) to head (853dff4).

Files Patch % Lines
...g_file/flush_manager_impl/defalut_flush_manager.rs 0.00% 68 Missing ⚠️
...tmq-common/src/common/thread/thread_service_std.rs 0.00% 51 Missing ⚠️
rocketmq-store/src/log_file/commit_log.rs 0.00% 32 Missing ⚠️
...ketmq-store/src/consume_queue/mapped_file_queue.rs 0.00% 25 Missing ⚠️
...og_file/flush_manager_impl/group_commit_request.rs 0.00% 10 Missing ⚠️
...q-common/src/common/thread/thread_service_tokio.rs 94.33% 6 Missing ⚠️
...q-store/src/message_store/default_message_store.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
+ Coverage   20.67%   21.07%   +0.40%     
==========================================
  Files         207      211       +4     
  Lines       13962    14239     +277     
==========================================
+ Hits         2886     3001     +115     
- Misses      11076    11238     +162     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxsm mxsm merged commit 425114b into main Jun 2, 2024
9 checks passed
@mxsm mxsm deleted the feature-417 branch June 2, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Implement message persistence to disk during transmission
3 participants