Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #313]🚀Read Commit log file from cmd #316

Merged
merged 2 commits into from
Apr 21, 2024
Merged

[ISSUE #313]🚀Read Commit log file from cmd #316

merged 2 commits into from
Apr 21, 2024

Conversation

mxsm
Copy link
Owner

@mxsm mxsm commented Apr 21, 2024

Which Issue(s) This PR Fixes(Closes)

Fixes #313

Brief Description

How Did You Test This Change?

@mxsm mxsm requested a review from TeslaRustor April 21, 2024 16:26
Copy link
Contributor

@antcarryele antcarryele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 0.46512% with 214 lines in your changes are missing coverage. Please review.

Project coverage is 17.16%. Comparing base (e163274) to head (857e714).

Files Patch % Lines
...ketmq-common/src/common/message/message_decoder.rs 0.00% 105 Missing ⚠️
...-common/src/common/compression/compression_type.rs 0.00% 46 Missing ⚠️
rocketmq-cli/src/content_show.rs 0.00% 40 Missing ⚠️
rocketmq-cli/src/command_line.rs 0.00% 10 Missing ⚠️
rocketmq-cli/src/bin/rocketmq_cli.rs 16.66% 5 Missing ⚠️
.../src/log_file/mapped_file/default_impl_refactor.rs 0.00% 5 Missing ⚠️
rocketmq-common/src/common/message.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
- Coverage   17.58%   17.16%   -0.43%     
==========================================
  Files         173      176       +3     
  Lines        9120     9344     +224     
==========================================
  Hits         1604     1604              
- Misses       7516     7740     +224     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxsm mxsm merged commit 0af81e1 into main Apr 21, 2024
7 of 9 checks passed
@mxsm mxsm deleted the feature-313 branch April 21, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Read Commit log file from cmd
5 participants