Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #297]🎨Optimize code struct #298

Merged
merged 1 commit into from
Mar 31, 2024
Merged

[ISSUE #297]🎨Optimize code struct #298

merged 1 commit into from
Mar 31, 2024

Conversation

mxsm
Copy link
Owner

@mxsm mxsm commented Mar 31, 2024

Which Issue(s) This PR Fixes(Closes)

Fixes #297

Brief Description

How Did You Test This Change?

@mxsm mxsm requested a review from TeslaRustor March 31, 2024 02:55
Copy link
Contributor

@antcarryele antcarryele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 58 lines in your changes are missing coverage. Please review.

Project coverage is 18.08%. Comparing base (55a9a96) to head (4d3e9fe).

Files Patch % Lines
...q-broker/src/topic/manager/topic_config_manager.rs 0.00% 21 Missing ⚠️
rocketmq-broker/src/broker_runtime.rs 0.00% 9 Missing ⚠️
...r/src/topic/manager/topic_queue_mapping_manager.rs 0.00% 6 Missing ⚠️
...oker/src/offset/manager/consumer_offset_manager.rs 0.00% 4 Missing ⚠️
.../src/offset/manager/consumer_order_info_manager.rs 0.00% 4 Missing ⚠️
...subscription/manager/subscription_group_manager.rs 0.00% 3 Missing ⚠️
...oker/src/filter/manager/consumer_filter_manager.rs 0.00% 2 Missing ⚠️
rocketmq-broker/src/out_api/broker_outer_api.rs 0.00% 2 Missing ⚠️
...mq-broker/src/schedule/schedule_message_service.rs 0.00% 2 Missing ⚠️
rocketmq-common/src/common/config_manager.rs 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
+ Coverage   18.06%   18.08%   +0.01%     
==========================================
  Files         168      168              
  Lines        8850     8844       -6     
==========================================
  Hits         1599     1599              
+ Misses       7251     7245       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxsm mxsm merged commit 1334fcf into main Mar 31, 2024
8 of 9 checks passed
@mxsm mxsm deleted the feature-297 branch March 31, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize code struct
3 participants