Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #1644]♻️Refactor PollingInfoProcessor#process_request method signature🔥 #1645

Merged
merged 1 commit into from
Dec 7, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions rocketmq-broker/src/processor/polling_info_processor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,22 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
use rocketmq_remoting::code::request_code::RequestCode;
use rocketmq_remoting::net::channel::Channel;
use rocketmq_remoting::protocol::remoting_command::RemotingCommand;
use rocketmq_remoting::runtime::connection_handler_context::ConnectionHandlerContext;

#[derive(Default)]
pub struct PollingInfoProcessor {}

impl PollingInfoProcessor {
fn process_request(
&self,
pub async fn process_request(
&mut self,
_channel: Channel,

Check warning on line 28 in rocketmq-broker/src/processor/polling_info_processor.rs

View check run for this annotation

Codecov / codecov/patch

rocketmq-broker/src/processor/polling_info_processor.rs#L26-L28

Added lines #L26 - L28 were not covered by tests
_ctx: ConnectionHandlerContext,
_request_code: RequestCode,

Check warning on line 30 in rocketmq-broker/src/processor/polling_info_processor.rs

View check run for this annotation

Codecov / codecov/patch

rocketmq-broker/src/processor/polling_info_processor.rs#L30

Added line #L30 was not covered by tests
_request: RemotingCommand,
) -> RemotingCommand {
) -> crate::Result<Option<RemotingCommand>> {

Check warning on line 32 in rocketmq-broker/src/processor/polling_info_processor.rs

View check run for this annotation

Codecov / codecov/patch

rocketmq-broker/src/processor/polling_info_processor.rs#L32

Added line #L32 was not covered by tests
todo!()
}
}
Loading