[ISSUE #1136]🚀Support broker receive transaction message-3

[mxsm]

Which Issue(s) This PR Fixes(Closes)

Fixes #1136

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

• New Features

  • Introduced a new trait for managing local transactional messages with asynchronous methods.
  • Added methods for preparing and deleting messages, as well as managing transaction metrics.

• Improvements

  • Enhanced error handling in message processing.
  • Refined message size handling to comply with broker configuration.

• Bug Fixes

  • Improved logging for transaction end requests in slave mode to prevent operations that are not allowed.

• Tests

  • Added unit tests for various scenarios in the transactional message processing.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request primarily focus on enhancing the EndTransactionProcessor and DefaultTransactionalMessageService implementations within the RocketMQ broker. Key modifications include updating method signatures to accept references to EndTransactionRequestHeader, improving error handling, and introducing new asynchronous methods for managing transactional messages. Additionally, a new trait for local transactional message services has been added, along with unit tests for the end_message_transaction function to validate its behavior under various scenarios.

Changes

File Path	Change Summary
rocketmq-broker/src/processor/end_transaction_processor.rs	- Added logging for warnings when broker role is Slave. - Refined handling of request_header. - Updated check_prepare_message method signature and logic. - Modified end_message_transaction to handle absent message tags. - Added unit tests for end_message_transaction.
rocketmq-broker/src/transaction/queue/default_transactional_message_service.rs	- Updated commit_message and rollback_message method signatures to accept references. - Enhanced get_op_message for size handling. - Improved error handling in delete_prepare_message.
rocketmq-broker/src/transaction/transactional_message_service.rs	- Introduced TransactionalMessageServiceLocal trait with new asynchronous methods. - Updated commit_message and rollback_message method signatures to accept references. - Added methods for transaction metrics management.

Assessment against linked issues

Objective	Addressed	Explanation
Support broker receive transaction message (1136)	✅

Possibly related PRs

• [ISSUE #702]🚀Support pull message result handle-2🚀 #706: Updates method signatures to accept a reference to EndTransactionRequestHeader, related to changes in the main PR.
• [ISSUE #710]🚀Support pull message result handle-3🎨 #721: Similar updates to commit_message and rollback_message methods, aligning with the main PR changes.
• [ISSUE #722]🚀Support pull message result handle-4 #728: Modifications to PullMessageResultHandler, which may interact with transaction processing changes.
• [ISSUE #761]🔥Optimize Pull message rewrite static topic🚀 #762: Changes in PullMessageProcessor, directly related to transaction processing logic in the main PR.
• [ISSUE #777]🔥Fix Broker can not started🐛 #778: Relevant changes to DefaultPullMessageResultHandler in the context of transaction processing.

Poem

🐰 In the land of code where bunnies play,
Transactions hop in a bright new way.
With headers refined and warnings in sight,
Our messages dance in the soft moonlight.
So let’s celebrate with a joyful cheer,
For smoother transactions, we hold dear! 🎉

Warning

Rate limit exceeded

@rocketmq-rust-bot has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 58 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 69ba1f1 and 006752b.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[rocketmq-rust-bot]

🔊@mxsm 🚀Thanks for your contribution 🎉. CodeRabbit(AI) will review your code first 🔥

[codecov]

Codecov Report

Attention: Patch coverage is 67.02128% with 31 lines in your changes missing coverage. Please review.

Project coverage is 17.54%. Comparing base (69ba1f1) to head (006752b).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...-broker/src/processor/end_transaction_processor.rs	70.78%	26 Missing ⚠️
...ion/queue/default_transactional_message_service.rs	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1218      +/-   ##
==========================================
+ Coverage   17.34%   17.54%   +0.19%     
==========================================
  Files         427      427              
  Lines       52948    53010      +62     
==========================================
+ Hits         9185     9301     +116     
+ Misses      43763    43709      -54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.