Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement⚡️] Add #[inline] for PutMessageResult methods #1689

Closed
1 task done
mxsm opened this issue Dec 9, 2024 · 2 comments · Fixed by #1701
Closed
1 task done

[Enhancement⚡️] Add #[inline] for PutMessageResult methods #1689

mxsm opened this issue Dec 9, 2024 · 2 comments · Fixed by #1701
Assignees
@nakul-py
Labels
Difficulty level/Easy Easy ISSUE enhancement⚡️ New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
v0.4.0

Comments

@mxsm
Copy link
Owner

mxsm commented Dec 9, 2024

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

Add #[inline] for PutMessageResult methods

Motivation

image

Describe the Solution You'd Like

No response

Describe Alternatives You've Considered

No response

Additional Context

No response
@mxsm mxsm added enhancement⚡️ New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Dec 9, 2024
@RocketmqRustBot RocketmqRustBot added this to the v0.4.0 milestone Dec 9, 2024
@mxsm mxsm mentioned this issue Dec 9, 2024
Open
@mxsm mxsm added the Difficulty level/Easy Easy ISSUE label Dec 9, 2024
@nakul-py
Copy link
Contributor

nakul-py commented Dec 9, 2024

Hi @mxsm
I came across this issue and would like to work on resolving it. Could you please assign it to me?

@mxsm
Copy link
Owner Author

mxsm commented Dec 9, 2024

Hi @mxsm I came across this issue and would like to work on resolving it. Could you please assign it to me?

@nakul-py sure!

@nakul-py nakul-py mentioned this issue Dec 9, 2024
Merged
rocketmq-rust-bot pushed a commit that referenced this issue Dec 9, 2024
@nakul-py
[ISSUE #1689]Adding inline for PutMessageResult methods (#1701)
67c35cb
This was referenced Dec 11, 2024
Merged
Merged
This was referenced Dec 24, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nakul-py nakul-py

Labels
Difficulty level/Easy Easy ISSUE enhancement⚡️ New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

[ISSUE #1689]Adding inline for PutMessageResult methods nakul-py/rocketmq-rust
3 participants
@mxsm @nakul-py @RocketmqRustBot