Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit for maximum resolution of videos #74

Closed
Rpsl opened this issue Jan 7, 2020 · 3 comments
Closed

Limit for maximum resolution of videos #74

Rpsl opened this issue Jan 7, 2020 · 3 comments

Comments

@Rpsl
Copy link
Contributor

Rpsl commented Jan 7, 2020

User Story: I want to download the video in good quality, but I don't want to download a few gigabytes of video because it is in 4k.

--

I think can add an optional item about maximum video quality (720p/1080p/1440p/2160p) to the config of feed and use it param for youtube-dl

https://github.com/mxpv/podsync/blob/master/pkg/ytdl/ytdl.go#L43

bestvideo[height<=720][ext=mp4]+bestaudio[ext=m4a]
@mxpv
Copy link
Owner

mxpv commented Jan 25, 2020

Hello. Thanks for the feedback. Is this something that you want to control from configuration file?

@Rpsl
Copy link
Contributor Author

Rpsl commented Jan 26, 2020

Yep. I think it maybe not requirement param of the feed in configuration file.

@SoftXperience
Copy link

Is this already included in release 2.0.7? It seems to not work on my machine. If I add max_height = 360 to my config, the video has still 1080p.
Also the readme shows max_height = "720", but as it is an Int, shouldn't it be max_height = 720?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants