This repository has been archived by the owner on Oct 6, 2022. It is now read-only.
native: change Video data type into openrtb2.Video #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Wwwmmxxx I'll merge this now, but will tag a final (v17, IIRC) during the weekend. |
|
Tagged v17-alpha for now, so it can be used right away https://github.com/mxmCherry/openrtb/releases/tag/v17.0.0-alpha.1 Maybe it could be fine with just minor version bump, but... It's fine to increment major version, maybe it can break the code in some cases 🤷 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #52. Using type alias to achieve, retain annotation in
native1.Video.goso that we could know why