feat: allow encoding of borrowed data #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaseizinger
commented
Sep 25, 2023
4 tasks
mxinden
reviewed
Sep 26, 2023
Comment on lines
+13
to
+14
| - Use GATs for `Encoder` trait to allow encoding of borrowed data. | ||
| See [PR 9](https://github.com/mxinden/asynchronous-codec/pull/9). |
There was a problem hiding this comment.
What do you think of including the diff to the LengthCodec below here to help folks upgrade to the new version?
There was a problem hiding this comment.
The diff is in the linked PR, isn't that equivalent?
There was a problem hiding this comment.
It reduces one step for users.I think it might safe them some time. Not a strong preference.
There was a problem hiding this comment.
Would prefer to just merge this to be honest :)
The compiler will also guide people to add the lifetime.
|
Friendly ping @mxinden. |
thomaseizinger
force-pushed
the
feat/gats
branch
from
b3b8633 to
5abbc48
Compare
mxinden
approved these changes
Oct 11, 2023
|
Tagged and published. Thank you @thomaseizinger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.