Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async/await #1291

Merged
merged 10 commits into from
Jul 25, 2022
Merged

Async/await #1291

merged 10 commits into from
Jul 25, 2022

Conversation

RomanPodymov
Copy link
Collaborator

Hello.
Thank you for PromiseKit.
Added compatibility with async/await.

mxcl
mxcl requested changes Jul 24, 2022
View reviewed changes
Copy link
Owner

@mxcl mxcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to pass CI, our strategy with these typically is to add the #if inside the test bodies so that they pass because they have no content.

@RomanPodymov
Copy link
Collaborator Author

Needs to pass CI, our strategy with these typically is to add the #if inside the test bodies so that they pass because they have no content.

Fixed.

@RomanPodymov RomanPodymov requested a review from mxcl July 25, 2022 10:29
@mxcl mxcl merged commit 087d65e into mxcl:v6 Jul 25, 2022
@mxcl
Copy link
Owner

mxcl commented Jul 25, 2022

v6.18.0 released. Thanks for the contribution.

@mxcl
Copy link
Owner

mxcl commented Aug 4, 2022

This broke probably an awful lot of people I will revert these changes if we cannot analyze the issue and fix it (with CI checks) within 24 hours.

Refs #1292

@mxcl
Copy link
Owner

mxcl commented Aug 10, 2022

K possibly this is just we now require a newer Xcode https://stackoverflow.com/questions/69284960/ios-concurrency-is-only-available-in-ios-15-0-0-or-newer-in-protocol

@RomanPodymov RomanPodymov mentioned this pull request Feb 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxcl mxcl mxcl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RomanPodymov @mxcl