add setting to be able to skip mandatory client cert auth #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxab
reviewed
Sep 14, 2023
|
Hey @n-marton, very cool! Great to see that people are trying out my project :) |
cool stuff :) |
|
merged it, thank you! After the merge I noticed that the test were failing, so I adjusted the method a little bit. I hope you don't mind :) |
ah sorry I have completely forgot about the test part, thanks for making a new tag out of it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey @mxab
we have a usecase where we don't have client certs, so making that optional might be useful for others as well
the default behaviour remains the same