Add support for docx xml containing a BOM #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XML files within the DOCX file may begin with a byte order mark. Node doesn't strip this out automatically, and XML strings passed to sax that start with the BOM sequence will cause read errors because the XML string will not begin with the XML declaration. References: nodejs/node-v0.x-archive#1918 nodejs/node-v0.x-archive#4039
|
Thanks for the pull request! I'm just wondering if it's worth pulling in a library rather than just implementing Also, if you could amend the commit to avoid the whitespace noise in the diff, that would be great. |
Replace with simple string.replace
|
I wondered about that myself. This does seem much more simple since the input is a string at this point in the code. |
|
Merged and published as 0.3.10. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XML files within the DOCX file may begin with a byte order mark. Node doesn't strip this out automatically when reading UTF-8 data as a string, despite setting UTF-8 encoding ( nodejs/node-v0.x-archive#1918 & nodejs/node-v0.x-archive#4039 ). When these strings are passed to sax, they will cause errors because the XML string will not begin with the XML declaration or a node ("Non-whitespace before first tag.").