Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid panicking, handle error #72

Merged
merged 1 commit into from
Oct 5, 2017
Merged

Conversation

nylar
Copy link
Contributor

@nylar nylar commented Oct 5, 2017

Handle error from http.NewRequest() and avoid panicking if client.Do() should fail.

@mweagle
Copy link
Owner

mweagle commented Oct 5, 2017

LGTM - thanks @nylar .

@mweagle mweagle merged commit ea7ce50 into mweagle:master Oct 5, 2017
@nylar nylar deleted the dont-panic branch October 5, 2017 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants