Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove container added when inferring default color for bar artist #3246

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Feb 6, 2023

Fixes an issue introduced in (#2449) that primarily affects histplot (e.g. #3241) because ax.bar adds both patches and a container for the patches, but the current code neglects to clean up the container (and it is used in some cases, e.g. by matplotlib's automatic legend code).

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #3246 (c8a4f1b) into master (0ebc82e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3246   +/-   ##
=======================================
  Coverage   98.43%   98.43%           
=======================================
  Files          77       77           
  Lines       24527    24530    +3     
=======================================
+ Hits        24143    24146    +3     
  Misses        384      384           
Impacted Files Coverage Δ
seaborn/distributions.py 96.35% <ø> (ø)
seaborn/utils.py 93.78% <100.00%> (ø)
tests/test_distributions.py 99.80% <100.00%> (+<0.01%) ⬆️

@mwaskom mwaskom merged commit 17f9788 into master Feb 7, 2023
@mwaskom mwaskom deleted the fix/histplot_phantom branch February 7, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant