Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass label when creating color cycle scout #3116

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Don't pass label when creating color cycle scout #3116

merged 2 commits into from
Oct 28, 2022

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Oct 28, 2022

Fixes #3115

import numpy as np
import seaborn as sns

rng = np.random.default_rng(43)
data = rng.random(1000)
ax = sns.histplot(data, label="Random Data", stat="density")
ax.legend()

image

@mwaskom mwaskom added the bugfix label Oct 28, 2022
@mwaskom mwaskom added this to the v0.12.2 milestone Oct 28, 2022
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #3116 (c6b51bc) into master (852ffaf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3116   +/-   ##
=======================================
  Coverage   98.41%   98.41%           
=======================================
  Files          76       76           
  Lines       24049    24056    +7     
=======================================
+ Hits        23668    23675    +7     
  Misses        381      381           
Impacted Files Coverage Δ
seaborn/utils.py 95.46% <100.00%> (+0.02%) ⬆️
tests/test_distributions.py 99.79% <100.00%> (+<0.01%) ⬆️

@mwaskom mwaskom merged commit 021a20f into master Oct 28, 2022
@mwaskom mwaskom deleted the fix/label branch October 28, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate legend entries for histplot
1 participant