Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid aggregating in lineplot when not necessary #3081

Merged
merged 2 commits into from
Oct 15, 2022
Merged

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Oct 13, 2022

Fixes #3006. See the issue for context.

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #3081 (70cfe98) into master (876bedd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3081   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files          74       74           
  Lines       23749    23758    +9     
=======================================
+ Hits        23368    23377    +9     
  Misses        381      381           
Impacted Files Coverage Δ
seaborn/relational.py 99.69% <100.00%> (+<0.01%) ⬆️
tests/test_relational.py 99.30% <100.00%> (+<0.01%) ⬆️

@mwaskom mwaskom removed the bugfix label Oct 13, 2022
@mwaskom mwaskom merged commit 1d70f58 into master Oct 15, 2022
@mwaskom mwaskom deleted the fix/lineplot_perf branch October 15, 2022 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance regression in lineplot with ci=None (or errorbar=None)
1 participant